Switch git versioning #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
openshift-ci
bot
added
the
approved
this commit changes all scripts necessary to generate task manifests. Scripts will now generate task manifests into release/tasks folder instead of tasks folder. At the same time this commit removed tag creation from release/tasks/*/ folder, because we will be swithing to git based versioning. This change will help reduce number of manifests located in repository - at the end we will have only templates and generated manifests at the repo. Signed-off-by: Karel Simon <[email protected]>
Signed-off-by: Karel Simon <[email protected]>
ksimon1
force-pushed
the
switch-git-versioning
branch
from
acd33c9
to
144f7e8
Compare
Signed-off-by: Karel Simon <[email protected]>
ksimon1
force-pushed
the
switch-git-versioning
branch
from
144f7e8
to
d6bf79d
Compare
0xFelix
approved these changes
Mar 13, 2024
| on: | ||
| pull_request: | ||
| branches: [ main ] | ||
| #Disable this job until https://github.com/artifacthub/hub/issues/3691 is resolved |
There was a problem hiding this comment.
Create an issue for it to be reenabled?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix, ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Switch to git versioning
this PR changes all scripts necessary to generate task manifests.
Scripts will now generate task manifests into release/tasks folder
instead of tasks folder. At the same time this commit removed tag
creation from release/tasks/*/ folder, because we will be swithing to git based
versioning. This change will help reduce number of manifests located in
repository - at the end we will have only templates and generated
manifests at the repo.
Release note: